Repository navigation
fix(zed): use the codegraph-mcp extension id - #206
Merged
Merged
Conversation
The registry rule is that an id must convey what the extension does, and the
docs phrase it as a suffix ("themes should be suffixed with -theme, snippets
with -snippets"). `-mcp` is the shortest form that satisfies it while keeping
the product name first, and the registry already hosts 14 such entries
including azure-mcp, sentry-mcp, prisma-mcp and chrome-devtools-mcp — several
of them binary-downloading context servers like this one. `codegraph-mcp` is
unoccupied.
The registry submodule directory and extensions.toml table key must equal the
id, so the publishing docs move with it. `[context_servers.codegraph]` does
not: it is independent of the id (the published chrome-devtools-mcp declares a
different one) and it is the key `codegraph install` writes into Zed's
settings.json, so renaming it would break existing configs.
Also drops a claim about what the extension store searches. Only the
dev-extension path is verifiable from Zed's source, where `name` is the
displayed headline; the store query is server-side.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 136 136
Lines 73024 73024
=======================================
+ Hits 69510 69511 +1
+ Misses 3514 3513 -1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #203, which shipped the id as
mcp-server-codegraph. Changing it tocodegraph-mcpbefore the registry entry goes live — an extension id cannot be changed after publication, so it is worth settling now.Why the suffix form
The binding rule is that the id must convey what the extension does, and the docs phrase it as a suffix:
-mcpsatisfies that while keeping the product name first. The registry already hosts 14*-mcpentries —azure-mcp,sentry-mcp,prisma-mcp,svelte-mcp,chrome-devtools-mcpamong them, several being binary-downloading context servers exactly like this one.codegraph-mcpis unoccupied.The previous
mcp-server-codegraphwas chosen off a raw count (44mcp-server-*prefix entries vs 0*-mcp-server), which overweighted precedent: the maintainer's own instruction on a sibling PR permitsmcp-serveras prefix or suffix, so "zero precedent for that exact string" was never a compliance problem, and the docs' own wording leans suffix.What moved, and what deliberately did not
The registry submodule directory and
extensions.tomltable key must equal the id, so the publishing instructions move with it.[context_servers.codegraph]stays. It is independent of the extension id — the publishedchrome-devtools-mcpdeclares[context_servers.chrome-devtools-mcp-zed]— and it is the key thatcodegraph install/codegraph init --target=zedwrites into Zed'ssettings.json. Renaming it would break every existing config for no gain.SERVER_IDandsrc/lib.rsare untouched.Version goes to
0.2.1, since0.2.0already shipped under the old id.Also corrected
A discoverability claim I had added in #203 said the extension store searches the
namefield. Only the dev-extension path is verifiable from Zed's source (crates/extensions_ui/src/extensions_ui.rs:560builds candidates frommanifest.name); the store path is a server-sidefetch_extensionsquery whose matched fields aren't visible from the client. The sentence now claims only whatextensions_ui.rs:802shows — thatnameis the displayed headline.Verification
grepfor the old id returns zero hits; nocontext_servers.codegraph-mcpanywhere;src/lib.rs,crates/, and the rootCargo.toml/Cargo.lockshow an empty diff.wasm32-wasip2andclippy --all-targets -- -D warningsclean, both from insideeditors/zed/(own workspace root).make cigreen at 127 suites / 3156 passed / 0 failed, matchingmain.